search

TeamCOMPAS / COMPAS

COMPAS rapid binary population synthesis code
http://compas.science
MIT License
64 stars 66 forks source link

Simultaneous merger and SN #722

Closed reinhold-willcox closed 1 year ago

reinhold-willcox commented 2 years ago

Describe the bug Copied from Slack Here is a system that experiences both a merger and a SN in the same timestep.

In its last timestep, this system goes through MT from a HG secondary onto a HeHG primary, leading to CE which results in a merger. Weirdly/annoyingly, the primary also undergoes a non-disruptive USSN in this same timestep. Some of the pre-/post- event parameters are a bit funny, and make it look a bit like the CE occured first, followed by the SN, followed by the MT, but I think that's just a result of how/when we "sample" those parameters in a given timestep. This happens 19 times in 100k binaries in a (mostly) fiducial run.

Label the issue urgency_low - This issue is not urgent severity_moderate - This is a moderately severe bug

To Reproduce Standard and detailed outputs included below (as .txt here for github, just convert them back to h5)

Versioning (please complete the following information):

grid.txt BSE_Detailed_Output_0.h5.txt COMPAS_Output.h5.txt

reinhold-willcox commented 1 year ago

Closing this issue as it falls under the umbrella issue #805