Some checks for dungeon spawning are missing. Found a dungeon in a jungle lake.

[sebkuip]

Common sense Info To check a checkbox: Insert a lower case X between the square brackets, you need to remove the space though.

• I play...
  • [x] With a large modpack
  • [ ] Only with CQR and its dependencies
• The issue occurs in...
  • [x] Singleplayer
  • [ ] Multiplayer
• [x] I have searched for this or a similar issue before reporting and it was either (1) not previously reported, or (2) previously fixed and I'm having the same problem.
• [ ] I am using the latest version of the mod (all versions can be found on Github under releases)
• [x] I read through the FAQ and I could not find something helpful (FAQ)
• [ ] I reproduced the bug without any other mod's except forge, cqr and its dependencies

• [ ] The game crashes because of this bug

  Versions Chocolate Quest Repoured ('latest' IS NOT a valid version! Please use the version string that shows up in the mod overview of forge): Chocolate_Quest_Repoured-1.12.2-2.3.1B Forge: 1.12.2-2.6.2.83 Minecraft: 1.12.2

Describe the bug A clear and concise description of what the bug is.

Dungeons are missing some checks for spawning. Shown here is a dungeon spawning inside a jungle lake.

To Reproduce Steps to reproduce the behaviour:

1. Fly around
2. Search for dungeons
3. Sometimes one is spawned in the water

Expected behaviour A clear and concise description of what you expected to happen.

No spawning in the water.

Screenshots If applicable, add screenshots to help explain your problem.

https://cdn.discordapp.com/attachments/607239584962838548/826774216858796063/unknown.png https://cdn.discordapp.com/attachments/607239584962838548/826774390254338048/unknown.png

Other Please note: log files and crash reports should be uploaded as a FILE and not as a copy-paste of the text it here. Upload the file to a site like Pastebin or similar and link it here!!

• Link to Crash report file:
• Link to log file:
• Other mods (that are necessary to produce the bug):
• Other mods (that are also installed): Tekxit Pi modpack.
• CQR config folder (link, only if you changed the configs):
• Other mod's configs (link):

[DerToaster98]

No, there are no checks missing. The lake in the jungle isn't it's own biome, it belongs to the jungle biome and the vegetated cave can spawn in jungles and in swamps, it is working as intended.

[sebkuip]

Toaster answered in the discord.