TeamChocoQuest / ChocolateQuestRepoured

ChocolateQuest Re-poured!
Other
75 stars 25 forks source link

CQR dungeon protection possibly causing crashes. #268

Closed Slayer5934 closed 3 years ago

Slayer5934 commented 3 years ago

Common sense Info To check a checkbox: Insert a lower case X between the square brackets, you need to remove the space though.

Describe the bug During some edge case block placement a crash occurse when the CQR protection system tries to read the value from the block. It is also worth noting that the XP Shower is never suppose to be able to get placed on the top or bottom of a block, and without CQR this does not occur; I think it might have something to do with that.

To Reproduce Steps to reproduce the behavior:

  1. Install openblocks
  2. Place XP Shower on the top or bottom of any block (This is not suppose to be possible anyways)
  3. Crash

Other Please note: log files and crash reports should be uploaded as a FILE and not as a copy paste of the text of it here. Upload the file to a site like pastebin or similar and link it here!!

DerToaster98 commented 3 years ago

we can't really fix this from our end. Please pass this to open blocks. Issue is probably how their "open block" class treats the metadata when it tries to get it for placement, and it doesn't like it when the item meta is passed to the block.

I made a workaround, but that solution is not ideal cause it doesn't really fix the problem, it only prevents the game from crashing

Slayer5934 commented 3 years ago

I created the issue on OpenBlocks but that mod has not been updated since mid-2019 so a fix on their end is unfortunately unlikely, I am unsure if there are any valid branches/forks to use instead that someone is updating however. Edit: Looks like the 1.16 branch is recently active however.

DerToaster98 commented 3 years ago

well, that could be a problem. However i just tested the workaround and it works, but like i said, it isn't really the best solution.

Slayer5934 commented 3 years ago

There is a 1.16 branch that is recently active, however I doubt the 1.12.2 version will get backported changes. I appreciate you going through the trouble to catch the crash even if it's not the best possible solution though, hopefully the mod author proves me wrong :p