TeamChocoQuest / ChocolateQuestRepoured

ChocolateQuest Re-poured!
Other
75 stars 25 forks source link

Crown and Head Dupes #280

Closed Mellohi138 closed 3 years ago

Mellohi138 commented 3 years ago

Common sense Info To check a checkbox: Insert a lower case X between the square brackets, you need to remove the space though.

Describe the bug It's a dupe bug with stacked heads and crown. I think it's caused with the crown attachment feature not knowing how to act when the item they're being used on is stacked.

To Reproduce Steps to reproduce the behavior:

NOTE: I'm going to use 31 wither skulls in here as an example. But please note that any type of head with any type of number works.

  1. Open a crafting GUI. 2x2 or 3x3. Any type.
  2. Place 31 wither skulls with a crown.
  3. The output should be 31 wither skulls with crown. And when you take the crowned skulls out the crafting grid only wastes 1 skull.
  4. When you try to take the crown out of the 31 skulls, you get 31 more normal skulls automatically per 1 crown take out.

Expected behavior Basically both the skulls and crowns getting duped because of it.

Screenshots https://cdn.discordapp.com/attachments/825840715631165501/842868237015318528/unknown.png https://cdn.discordapp.com/attachments/825840715631165501/842868257358348310/unknown.png https://cdn.discordapp.com/attachments/825840715631165501/842869717634646016/unknown.png https://cdn.discordapp.com/attachments/825840715631165501/842871242087858226/unknown.png

Other

DerToaster98 commented 3 years ago

I don't even know why it is attachable to skulls, that shouldn't be the case

Mellohi138 commented 3 years ago

Probably because the player can wear them, just like helmets.

DerToaster98 commented 3 years ago

ye, the code only checked if the item can be worn on the head and didn't care about stack sizes

DerToaster98 commented 2 years ago

Fixed in 2.6.0B