TeamChocoQuest / ChocolateQuestRepoured

ChocolateQuest Re-poured!
Other
75 stars 25 forks source link

Shader crash on MacOS #302

Closed DarklyNightly closed 2 years ago

DarklyNightly commented 2 years ago

Common sense Info To check a checkbox: Insert a lower case X between the square brackets, you need to remove the space though.

Describe the bug The game crashes on start up

To Reproduce Steps to reproduce the behavior:

  1. press play
  2. wait for loading
  3. crash . . .

Expected behavior The Main Menu to appear for mc

Screenshots If applicable, add screenshots to help explain your problem.

Other Please note: log files and crash reports should be uploaded as a FILE and not as a copy paste of the text of it here. Upload the file to a site like pastebin or similar and link it here!!

DerToaster98 commented 2 years ago

Please reproduce this with only cqr and it's dependencies

Meldexun commented 2 years ago

We need the log to be able to resolve this issue.

DarklyNightly commented 2 years ago

random.zip here is the zip

DerToaster98 commented 2 years ago

we need the logfile, not your whole modpack. The problem is likely related to your hardware, so sending the modpack won't help

WolfBV commented 2 years ago

Different person, same crash, only CQR and geckolib. https://pastebin.com/TfWN2T6b

Meldexun commented 2 years ago

What is your cpu/gpu and what is your graphics driver version? Intel HD 4000 should support up to OpenGL 4.0 and CQR requires OpenGL 3.0. So updating your graphics driver should be enough.

WolfBV commented 2 years ago

I think it might be something with GLSL, idk https://stackoverflow.com/questions/31803872/opengl-glsl-shaders-on-mac-does-not-compile

cpu is 2.5 GHz Intel Core i5. gpu is Intel HD Graphics 4000 1536 MB.

I don't think updating my drivers will help, Rubyz67 is two OSX versions ahead of me.

Additional link only because it shares the "ERROR: 0:1: '' : version '130' is not supported" https://github.com/JuliaGL/GLVisualize.jl/issues/81

WolfBV commented 2 years ago

Issue appears after the Beta 6.0 update.

DerToaster98 commented 2 years ago

Issue appears after the Beta 6.0 update.

That is only logical cause that shader got added in 2.6.0B, it can't appear in lower versions.

DerToaster98 commented 2 years ago

Anyway, please try to update your graphics driver, even if the other person has a newer OS version.

However, thanks for also reporting, the infos you gave us are useful

DarklyNightly commented 2 years ago

yw

DarklyNightly commented 2 years ago

my graphics Intel Iris Graphics 6100 1536 MB

DarklyNightly commented 2 years ago

it says i have support for open gl 2.1+

xJon commented 2 years ago

We're also getting reports of crashes using the latest version of CQR: https://github.com/xJon/Hexxit-II/issues/77 Crash report: https://pastebin.com/pd7rz22y Note that they're using OpenGL: Apple M1 GL version 2.1 Metal - 76.1, Apple.

DerToaster98 commented 2 years ago

We haven’t published the patch yet. Try updating your GPU drivers

DerToaster98 commented 2 years ago

Problem seems to be that the used GPUs (maybe in general on macos?) only support up to ogl 2.1. CQR requires at least 3.0.0

I‘m not an expert on that though

xJon commented 2 years ago

That's odd because the crash log also specifies;

GL Caps: Using GL 1.3 multitexturing.
           Using GL 1.3 texture combiners.
           Using framebuffer objects because ARB_framebuffer_object is supported and separate blending is supported.
           Shaders are available because OpenGL 2.1 is supported.
           VBOs are available because OpenGL 1.5 is supported.
DerToaster98 commented 2 years ago

Like i said: i‘m not an expert in the topic of shaders. We have a fix though but the update is not ready

btparrish commented 2 years ago

is there a quick fix for mac users on this?

DerToaster98 commented 2 years ago

The only thing you could do is 1) fix the shader for us 2) try updating your graphics card drivers

those are all your options

btparrish commented 2 years ago

so this is actually an issue with the shader included in Hexxit, not Chocolate Quest?

DerToaster98 commented 2 years ago

The shader is part of CQ so no

btparrish commented 2 years ago

Oh okay -- looks like my friend's graphics drivers are up to date so we'll have to wait on a fix. Thanks!

CPlusPatch commented 2 years ago

I'm pretty sure that graphics drivers on MacOS can't be updated, they are built into system updates. The latest macOS Monterey 12.1 still hasn't fixed the issue for me (CQR is still crashing)

btparrish commented 2 years ago

Any updates on this?

CPlusPatch commented 2 years ago

It seems like someone will have to change the code to make it OSX-compatible, as it's just not possible to use OpenGL 3.0 on a Mac

https://stackoverflow.com/questions/41120025/isnt-it-possible-to-run-opengl-3-0-on-macbok-pro-2015-mid-with-glfw3

DerToaster98 commented 2 years ago

I think Meldex rewrote the shader to use openGL 1.1.

If you want to test it: Replace these files in the mod jar with these: File path: <Mod jar root>assets/cqrepoured/shaders/sphere/ Files to replace: vertex.glsl, fragment.glsl

New files: f ragment.glsl: https://raw.githubusercontent.com/TeamChocoQuest/ChocolateQuestRepoured/master/src/main/resources/assets/cqrepoured/shaders/sphere/fragment.glsl vertex.glsl: https://raw.githubusercontent.com/TeamChocoQuest/ChocolateQuestRepoured/master/src/main/resources/assets/cqrepoured/shaders/sphere/vertex.glsl

DerToaster98 commented 2 years ago

If you can't do this wait for the next release

DerToaster98 commented 2 years ago

Please note that the solution provided above may rely on changes in the mod's program logic so it might not work or have consequences

DerToaster98 commented 2 years ago

This is potentially fixed in v2.6.3B, which was published yesterday

DerToaster98 commented 2 years ago

fixed in v2.6.3B

Reopen if it still crashes with the new update