TeamChocoQuest / ChocolateQuestRepoured

ChocolateQuest Re-poured!
Other
75 stars 25 forks source link

Spear Mouse Handler NPE Crash #303

Closed mxnmnm closed 2 years ago

mxnmnm commented 2 years ago

Common sense Info To check a checkbox: Insert a lower case X between the square brackets, you need to remove the space though.

Describe the bug Crash related to spears despite me not using anything from the mod (maybe one of the mobs attacking me was? I was in the middle of an onslaught raid [custom made and I don't remember giving them weapons from this mod]

To Reproduce Steps to reproduce the behavior: It seems to happen when I'm killing mobs with a sword (I am in the middle of a custom onslaught raid [not using weapons from this mod])

Expected behavior No crash

Other Please note: log files and crash reports should be uploaded as a FILE and not as a copy paste of the text of it here. Upload the file to a site like pastebin or similar and link it here!!

if you need more info let me know

DerToaster98 commented 2 years ago

First: Please reproduce that this issue is caused by our mod, you use a lot of additional mods that could cause it too.

It would also be good to know if one of the raid entities (or a different player) used a spear

mxnmnm commented 2 years ago

None of them were holding spears as far as I know. I cannot reproduce it because it was only in a specific situation that kept crashing (which was resolved by not attacking and letting myself die). I should have made a backup, but it was in the heat of the moment and I wasn't thinking lol.

DerToaster98 commented 2 years ago

Uhm ok, we need to see if my workaround fixes it but it honestly makes no sense that it crashes that way

mxnmnm commented 2 years ago

Well I'll be play testing my pack quite a bit, so if it comes up again we'll know that the workaround didn't work.

mxnmnm commented 2 years ago

I managed to recreate it, so send me an updated version for testing :D

DerToaster98 commented 2 years ago

Will do later

DerToaster98 commented 2 years ago

Here's a build with a workaround in it, please test if it is fixed now

Test build: Taken down because people were downloading it too often!

mxnmnm commented 2 years ago

It seems to be doing ok for now, but I might just test it on a server with my friend to see if it happens again, just to be safe. I'll update you after we've gone through a few raids with no issues.

Tot7uafag commented 2 years ago

had this crash before, it happens when mobs use spears, specially ones from AW2

Reveax commented 2 years ago

Here's a build with a workaround in it, please test if it is fixed now

Test build: Taken down because people were downloading it too often!

Same problem here, is the build still available for download somewhere?

DerToaster98 commented 2 years ago

No, i took that build down cause people were reuploading it and distributing it.

Also it was never meant to be actually used, it was just a test if the fix worked.

DerToaster98 commented 2 years ago

fixed in v2.6.3B