search

TeamDman / PlusTiC

Minecraft mod for adding new tools to and integrating various mods with Tinkers Construct
Apache License 2.0
7 stars 15 forks source link

Fixed Simply Jetpacks integration #38

Closed Pelotrio closed 2 years ago

Pelotrio commented 2 years ago
Pelotrio commented 2 years ago

Fixes #33, Fixes #29

TeamDman commented 2 years ago

LGTM. Thanks for the email, seems I didn't have notifications for this repo enabled so I didn't see this. Will try to get a build out in a minute with this

TeamDman commented 2 years ago

https://www.curseforge.com/minecraft/mc-mods/plusticminusbad/files/3645594

Pelotrio commented 2 years ago

@TeamDman first of all thanks for the quick response time and the relase. As I mentioned in the email, the version number is not replaced correctly in the mcmod.info file and in the main class. For this reason Plustic is shown as version @version@. This is also the case with the latest version. It's not a big deal, I just wanted to mention it. I can also submit a pull request to fix the build script if you want.

TeamDman commented 2 years ago

If you know an easy fix for the version tag stuff then please feel free to PR it It seems there's still some issues with the jetpack integration https://github.com/TeamDman/PlusTiC/pull/38#issuecomment-1037094796 I'll try to take a look at it soon hopefully

Pelotrio commented 2 years ago

If you know an easy fix for the version tag stuff then please feel free to PR it It seems there's still some issues with the jetpack integration #38 (comment) I'll try to take a look at it soon hopefully

Yeah I already fixed that in my dev environment because it was annoying me. What issues are you talking about exactly with the jetpack integration? I thought I tested it pretty well and the display messages should now also work. This was all done on with the newest version of Simply Jetpacks 2.

TeamDman commented 2 years ago

idk someone in the other issue said they still had a crash, maybe they had an outdated version

TeamDman commented 2 years ago

whoops, pasted the link to this PR instead of the issue https://github.com/TeamDman/PlusTiC/issues/33

Pelotrio commented 2 years ago

idk someone in the other issue said they still had a crash, maybe they had an outdated version

First of all, you have uploaded an incorrect jar. You probably ran the jar instead of the build task. The jar is not obfuscated and causes a crash. I decompiled the jar and confirmed that. The stack trace from the issue is identical to the one before my pr, so it is from an outdated version. Why don't you test once when you or someone else tries to fix something?

TeamDman commented 2 years ago

https://howoldisminecraft1122.today/ will try to get a working build up soon.

Pelotrio commented 2 years ago

https://howoldisminecraft1122.today/ will try to get a working build up soon.

If you merge my pr for the buildscript you should just have to run the build task and it should generate the correct jar. I can also send you my working build if you want to.

TeamDman commented 2 years ago

Please try latest build, sorry for the issues. Thanks for the help btw https://www.curseforge.com/minecraft/mc-mods/plusticminusbad/files/3648592 Actually launched a multimc instance without crashing this time too :P

Pelotrio commented 2 years ago

Yep it starting just fine and the jetpack integration also works without problems. Thank you very much and nice that you finally tested it :P.