TeamDman / SuperFactoryManager

Mozilla Public License 2.0
49 stars 19 forks source link

Fix runtime inventory shift #65

Closed BlueAgent closed 4 years ago

BlueAgent commented 4 years ago

This PR fixes one of the semi-related issues brought up by @desagas in https://github.com/TeamDman/SuperFactoryManager/issues/55, addressing this minimally by including all tiles when assigning ID mappings.

The issue occurs because some mods expose different capabilities on the server vs the client side. This can result in a desync of inventory mappings.

The more ideal way to address this would be to synchronize the inventories between the server and the client but this should be good enough till then. @desagas has been testing out this fix for a while and no issues have cropped up.

To work with the potentially increased number of tiles being tracked, the cable length / depth and inventory limit is also doubled. Probably would be good if there was some indicator for players if the limit is reached, but that's out of scope for this PR.

TeamDman commented 4 years ago

https://www.curseforge.com/minecraft/mc-mods/super-factory-manager/files/3061425