TeamDman / SuperFactoryManager

Mozilla Public License 2.0
35 stars 15 forks source link

Generate all the splits before executing them. #69

Closed md5i closed 3 years ago

md5i commented 3 years ago

This is a potential fix for Issue #68. I haven't programmed much in Java of late, and I've never delved into Minecraft mods before, so there may be many better ways to do this than this.

TeamDman commented 3 years ago

Been busy, got some time today to try and look at this. Getting 1.12 workspaces working again are a pain in the ass, I've gotten far enough to launch but it seems to have broken all resources image

idk if there's an easy fix for this, but won't be able to push a new build like this and I'm not able to invest much time into trying

I don't really support older versions, but it might be nice to attach a jar to your issue you created if people care to find a version fixing this specific issue.

Will likely be closing issues for old versions and stuff later, just haven't gotten around to it

md5i commented 3 years ago

I don't know exactly what to say, other than I was able to get it working and did not have texture problems. I don't know what your development environment is like, though. This was the first time I had attempted running Minecraft with an attached mod in Eclipse for debugging, so it took quite a bit of experimentation to get things up and running. I could send the gradle modification I had to make, if you think that might help.

TeamDman commented 3 years ago

Tried again today, and the textures were working. Note to future self: had to use the runClient task since the genIntellijRuns task didn't work, and creating a custom task to launch the GradleStart probably involves a prerequisite build step that I forgot. Will try and verify that there's no sus behaviour then will push a new build