information in JEI cannot be localized - Githubissues

TeamDman / Zen-Summoning

A mod that allows for pack creators to set up custom summoning situations using ZenScript

2 stars 1 forks source link

information in JEI cannot be localized #4

Closed idyllist123 closed 5 years ago

idyllist123 commented 5 years ago

https://imgur.com/YDVoGV3

TeamDman commented 5 years ago

The JEI string is grabbed from the entity's translated name https://github.com/TeamDman/Zen-Summoning/blob/master/src/main/java/ca/teamdman/zensummoning/client/jei/AltarRecipe.java#L49 I'll look into allowing for translation of the prefix string

TeamDman commented 5 years ago

https://minecraft.curseforge.com/projects/zen-summoning/files/2706217 Added a localization string with parameters for quantity and entity name Feel free to comment again if this still needs work

xinyuan-liu commented 5 years ago

https://github.com/TeamDman/Zen-Summoning/blob/2f36afd38924c434b5604cd050e92e48b916ccbf/src/main/java/ca/teamdman/zensummoning/client/jei/AltarRecipe.java#L32 This line also need to be localized.

xinyuan-liu commented 5 years ago

And the localization for entity name seems not actually working.

TeamDman commented 5 years ago

Thanks for the help! New build being approved https://minecraft.curseforge.com/projects/zen-summoning/files/2720629 Let me know if there's anything else that needs improvement!