search

TeamDmfMM / Catwalks-4

An updated version of Catwalks3 ported from the original Kotlin code
GNU General Public License v3.0
2 stars 0 forks source link

Prevent or manage snow settling #16

Closed AechtRob closed 3 years ago

AechtRob commented 4 years ago

Using the latest version for 1.12.2 snow settles on the catwalks, but "on top" of them, rather than falling down to the walkway. It just floats above the catwalks. If this is too hard to fix, can you prevent the catwalks from gathering snow at all (like path blocks)?

AechtRob commented 3 years ago

I have looked at this for you. What you need is this adding to the CatwalkBlock class. Or perhaps even to the whole GenericBlock as this will be an issue with all the blocks in the mod I think. Do any of your blocks require snow to settle on them?

The snow is settling because snow settles on any block with a solid upper face. You are overriding some of the vanilla block class, but have not overridden the upper block face property:

    ```

@Override public net.minecraft.block.state.BlockFaceShape getBlockFaceShape(net.minecraft.world.IBlockAccess worldIn, net.minecraft.block.state.IBlockState state, net.minecraft.util.math.BlockPos pos, net.minecraft.util.EnumFacing face) { if (face == net.minecraft.util.EnumFacing.UP) { return net.minecraft.block.state.BlockFaceShape.UNDEFINED; }

        return super.getBlockFaceShape(worldIn, state, pos, face);
    }