search

TeamDmfMM / Extra-Food

A mod that adds... extra food. The clue's in the name!
GNU General Public License v3.0
5 stars 3 forks source link

Textures issues #44

Closed LemADEC closed 7 years ago

LemADEC commented 7 years ago

As of ExtraFood-1.10.2-0.8.6, there's a lot of textures that are way too big in the assets folders: generally too large or mostly empty. After a quick testing, it appears at least 88% of the mod JAR file contains assests that are not needed by the mod. Also, according to forge, some textures are having broken aspect ratio:

[22:27:12] [Client thread/ERROR] [TEXTURE ERRORS/]:     The following other errors were reported for domain extrafood:
[22:27:12] [Client thread/ERROR] [TEXTURE ERRORS/]: -------------------------
[22:27:12] [Client thread/ERROR] [TEXTURE ERRORS/]:     Problem: broken aspect ratio and not an animation
[22:27:12] [Client thread/ERROR] [TEXTURE ERRORS/]:       textures/blocks/Oven.png
[22:27:12] [Client thread/ERROR] [TEXTURE ERRORS/]:       textures/blocks/CheesePress.png
dmf444 commented 7 years ago

Any issues caused by this? I mean, is a couple of textures that huge of an issue?

I know about the aspect ratio stuff, that's been there since day 1, but it's either that or a square texture that is half empty.

LemADEC commented 7 years ago

We're hunting an FPS lag in our pack. It's related to textures according to the integrated profiler. We've seen a few mods having huge textures (512x512 and higher) in the past and they always contributed into causing FPS lag.

LemADEC commented 7 years ago

Regarding the aspect ratio, you can have common texture images by adjusting your UV map. Practically, wrong ratio causes issues in Mipmap computation when the game doesn't extend back to a square.

dmf444 commented 7 years ago

I'll be cleaning this up later for a second 1.10.2 release as well as the 1.11.2+ releases