search

TeamDmfMM / StarvationAhoy

Starvation Ahoy's Official Repository
4 stars 1 forks source link

Major performance issues from excessive HTArmor instantiation #39

Open sfPlayer1 opened 8 years ago

sfPlayer1 commented 8 years ago

The client proxy instantiates HTArmor for every query to getArmorModel. The method is being called for every frame, player and armor stand wearing the armor. Creating a new instance not only bypasses the model's caching facilities, but causes also a lot of overhead behind the scenes.

With my current GPU+driver the HTArmor handling alone drops the frame rate to less than half.

Please change the client proxy to only instantiate the model on the first query and keep the instance cached in a field for future uses.

MeatHangerModel has a similar problem, please verify that all your models are only instantiated on the first use.

This problem needs to be addressed urgently for BTM.

dmf444 commented 8 years ago

Noted. Working on another build for BTM, so I'll add this all in.