search

TeamEpochGithub / agogos

Package that creates the underlying construction of a machine learning pipeline
MIT License
3 stars 0 forks source link

ENH: Update pre-commit config configure pre-commit.ci #86

Closed Jeffrey-Lim closed 1 week ago

Jeffrey-Lim commented 1 week ago

Updates the pre-commit config to be the same as for epochalyst. Also sets up pre-commit.ci

Currently, the pre-commit checks fail, but they were already failing on main before. I already fixed a few easy ones, but I see it as a separate issue to fix the rest. Most of them are either the overuse of typing.Any, which we should be able to replace with generics, or accessing private class members or functions, which would be a significant refactor that affect epochalyst as well.

EWitting commented 1 week ago

Looking at the ruff errors, I think it makes the most sense to make _set_hash and _set_parent public, and ignore the disallowance of typing.Any. The purpose of agagos is to allow everything. Either allow Any, or implement this with generics if possible, at least one of those two should be done to allow the pipeline to pass and merge.

Jeffrey-Lim commented 1 week ago

Looking at the ruff errors, I think it makes the most sense to make _set_hash and _set_parent public, and ignore the disallowance of typing.Any. The purpose of agagos is to allow everything. Either allow Any, or implement this with generics if possible, at least one of those two should be done to allow the pipeline to pass and merge.

I already created #87 and #91 for this, but I'll ignore these errors for now.