Minor bug in the decoder.

TeamErlich / dna-fountain

DNA-Fountain

http://dnafountain.teamerlich.org/

GNU General Public License v3.0

151 stars 48 forks source link

Minor bug in the decoder. #2

Open sm-hwang opened 6 years ago

sm-hwang commented 6 years ago

Hello,

I believe I have found a minor bug that causes the decoder to reject more oligos than necessary. When screening the oligo for homopolymers and GC content in the add_dna method from glass.pyx, the droplet in question does not contain its rs code. This might cause the oligo's GC content to shift outside of the designated range and cause its rejection.

I hope this helps, Munsu

sosoJuly822 commented 1 month ago

I tried to directly convert the FASTA file generated during the encoding process to FASTQ for decoding, but I couldn't get the correct output. Is this the reason?