TeamEver / everblock

Free Prestashop HTML block module
https://www.team-ever.com/prestashop-module-bloc-editeur-html-illimite-shortcode/
Academic Free License v3.0
13 stars 8 forks source link

Forgotten </div> #11

Closed bogwero closed 11 months ago

bogwero commented 1 year ago
<!-- Module Ever Block -->
{if isset($everblock) && $everblock}
        {foreach from=$everblock item=item}
            {if isset($item.block.add_container) && $item.block.add_container == 1}
            <div class="container">
            {/if}
            <div class="everblock everblock-{$item.block.id_everblock|escape:'htmlall':'UTF-8'} {$item.block.css_class|escape:'htmlall':'UTF-8'} {$item.block.bootstrap_class|escape:'htmlall':'UTF-8'} everhook-{$everhook|escape:'htmlall':'UTF-8'}" id="everblock-{$item.block.id_everblock|escape:'htmlall':'UTF-8'}" data-everposition="{$item.block.position|escape:'htmlall':'UTF-8'}" data-everhook="{$everhook|escape:'htmlall':'UTF-8'}"{if isset($item.block.background) && $item.block.background} style="background-color:{$item.block.background|escape:'htmlall':'UTF-8'};"{/if}>
                {$item.block.content nofilter}
            </div>
            {if isset($item.block.add_container) && $item.block.add_container == 1}
            </div>
            {/if}
        {/foreach}
    </div> **<- Did you forget about this </div> ?**
{/if}
<!-- /Module Ever Block -->
Luifer-dnk commented 1 year ago

$item.block.content nofilter

Are you referring to this file?

image

Which version do you use?

bogwero commented 1 year ago

Hi, First of all, thank you for the great module and I apologize for not being more specific. Yes, this is the file: https://github.com/TeamEver/everblock/blob/master/views/templates/hook/everblock.tpl I am using the latest 4.11 everblock plugin version. To replicate the issue please change position of the block, for example on the front page, on the displayHome hook, from last position (3 in my case) to 2 or 1, before the Featured Products or Best sellers and see that the </div> in question will break the layout of the page. From what I've seen in the code of the previous versions of the plugin, there was a <div class='container'> if I remember correctly, which was removed in the 4.11 version and this </div> probably was it's closing tag.

Kind regards!

Luifer-dnk commented 12 months ago

@bogwero you can close thread by solved ?

Many thanks.

bogwero commented 11 months ago

I close it, but how is it solved? The orphan

is still there.

Kind regards