Ignite Bug - Crit refreshing ignite dot causing it to not deal damage

[ZachRobins]

Describe the bug When mages crit before the 2s tick of Ignite, it refreshes the dot causing it to not deal any damage at all. This is most noticeable on Loatheb where mages will crit every fireball leading to no/very little ignite damage when they should be top dps from the fight because of ignite.

Quest/Item/Spell Link If this is quest, item or spell related, please put the link here. (https://www.wowhead.com/classic/spell=12848/ignite)

To Reproduce Steps to reproduce the behavior: Scorch or Fireball a mob with 1-5 mages with max crit, and ignite will do no damage.

Expected behavior In Classic Wow, the ignite deals damage every 2s regardless of the timing of the refresh. See this log of top Loatheb DPS with perma uptime on ignite from a single mage using scorch(1.5s cast) and constant critting refreshing. https://vanilla.warcraftlogs.com/reports/XTP7W8DR2n3qfyx1#fight=96&type=damage-done

Here is a vanilla video, showcasing the correct behaviour of ignite dealing damage while being constantly rolled/refreshed. https://www.youtube.com/watch?v=bMWKNeIISmo

Screenshots On this Everlook log, you can see that the ignite is dealing very little damage when it should be a significant portion https://vanilla.warcraftlogs.com/reports/g4dFNpPznWaHDVZT#fight=23&type=damage-done&ability=-12654

Additional context Add any other context about the problem here.

[NiDiCi]

Tested it, and the problem is just as described

[vetu104]

https://github.com/vmangos/core/commit/20f210a8e3a9fdac52e67847b80733e973b03755 https://github.com/vmangos/core/pull/1050

Reverting this commit would make ignite behave like players expect. I don't know what implications it would have on other spells though.

Video of me testing this on my local server running latest vmangos (13c4399) but the commit reverted: https://0x0.st/XoIs.mp4