Memory leak: Thread is not deleted when uma0 is used

TeamFAPS / PSVita-StorageMgr

kernel plugin that automatically mounts/redirects any storage device on any mount points you want

GNU General Public License v3.0

384 stars 40 forks source link

Memory leak: Thread is not deleted when uma0 is used #64

Closed gnuton closed 5 years ago

gnuton commented 5 years ago

I guess this PR doesn't need explanations. BTW the workaround function always fails on my vita 2004 with 3.65 firmware

CelesteBlue-dev commented 5 years ago

When return 0 is called, doesnt it exit the thread ? (of course the thread is not deleted but does it matter ?)

When we call ksceKernelExitDeleteThread(0); is the return 0; line below executed or not ?

About the failing workaround on slim vita 3.65, please test on 3.60, and please test gamesd.skprx from xyz ( though I havent looked if his workaround remounts uma0).

gnuton commented 5 years ago

About leaking memory leaving zombies threads: https://stackoverflow.com/questions/17345647/how-many-threads-can-a-c-application-create

As for the workaround, it may work on 3.60 but what I'm saying if that maybe that function is useless on 3.65. But I may address this in another issue/PR