search

TeamForbiddenLLC / warfork-qfusion

Warfork is powered by Qfusion a 3D game engine. Qfusion is a fork of id Tech 2, popularly known as the Quake II engine. Qfusion is free and open-source software subject to the terms of the GNU General Public License.
https://warfork.com
103 stars 44 forks source link

use all 50 reaction kill sounds, instead of only 3 #382

Open Gauley123 opened 1 month ago

Gauley123 commented 1 month ago

currently only 3 of the reaction kill sounds are used but there are 50 in the assets this makes it so all 50 reaction kill sounds can be used

pollend commented 1 month ago

I lack context, the code looks good to me just looking at it.

velzie commented 1 month ago

what exactly does this do?

Gauley123 commented 1 month ago

@velzie when using cg_reactionKills 1 only 3 voice lines can be heard at the moment but there are 50 in the assets. this pr lets all 50 be heard

pollend commented 1 month ago

this is what caine mentioned:

Models haven’t been made for the characters I had in mind They’re not applicable to the current models in any capacity and don’t make sense as is It’ll be a long time before that happens sorry Three was used for internal testing only so the game isn’t loading useless sounds Instead of 250 You could probably have it load all 250 if it’s a Debug build and just not load any if it’s a release Another issue is it might impact game load times severely iirc and or crash the sound engine due to some limitation michaelp would need to investigate Iirc sounds start being delayed and out of sync Or console floods with errors