search

TeamGalacticraft / Galacticraft-Legacy

An advanced Space Dimension Mod for Minecraft
MIT License
72 stars 33 forks source link

fix: Add back suffocation damage #166

Closed benreid24 closed 11 months ago

benreid24 commented 11 months ago

Resolves #165

Weirdly, if I checked the isCancelled() property on the event before applying the damage then the damage would never get applied. Unconditionally applying damage here seems to work fine.

ROMVoid95 commented 11 months ago

the method was just missing the entityLiving.attackEntityFrom statement. I guess I brought this change from another branch locally by accident But the check for cancelled can't just be removed.