search

TeamGalacticraft / Galacticraft

The classic space mod, rewritten for modern versions of Minecraft.
MIT License
417 stars 83 forks source link

Feat: Added Fallen Meteor #206

Closed SteveKunG closed 1 year ago

SteveKunG commented 2 years ago

Seperate from #124

~My current fix concept is made HeatLevel into 0-4 heat block state. This should be better than updating block color every tick.~

~Still has bad performance when multiple fallen meteors are in one chunk.~ Fixed! 2021-11-23_01 43 36

DarianLStephens commented 2 years ago

Are they still block entities? I feel like it would be better if they were regular blocks with differently-colored models for the states that just updated heat level on weighted random tick, since it barely changes anything. Since last I recall, the color changes in stages anyway, there should be no outward impact on visuals. FPS will probably still struggle with so many hot meteors in a chunk because it's updating all that complex geometry so often, but once they cool down, there should be next to no additional performance impact.

SteveKunG commented 2 years ago

@DarianLStephens Yeah, I'm going to phase it out.

This is actually good so far. 2021-11-23_11 25 25

SteveKunG commented 2 years ago

Testing with both FPS and TPS are fine.

2021-11-23_14 52 46

DarianLStephens commented 1 year ago

Eyy, it finally got merged!