Game crash on /give player rocket

TeamGalacticraft / Galacticraft

The classic space mod, rewritten for modern versions of Minecraft.

MIT License

402 stars 85 forks source link

Game crash on /give player rocket #255

Closed supersimple33 closed 5 months ago

supersimple33 commented 1 year ago

Mod Loader

Fabric

Version Information

7d5137c

Reconfirmed in 13285bb

Log or Crash Report

https://gist.github.com/supersimple33/f5ec952b49319ca606d7b48ef44b311a

Reproduction steps

When running /give @p galacticraft:rocket the game crashes. I believe it could have something to do with the rotating texture of the item.

supersimple33 commented 1 year ago

Appears as though this is expected for now as the problem is from a nbt tag which for the rocket which is null since they have not been implemented in the API. As a workaround a null check could be added in RocketDataImpl but I think such a temporary work around is unnecessary.

I'll leave the issue open since it is technically still a problem.

supersimple33 commented 5 months ago

Fixes confirmed