fix: Walkways and Grating - Githubissues

TeamGalacticraft / Galacticraft

The classic space mod, rewritten for modern versions of Minecraft.

MIT License

402 stars 85 forks source link

fix: Walkways and Grating #264

Closed SteveKunG closed 1 year ago

SteveKunG commented 1 year ago

Added fluid falling block state to Grating and Walkways.
Change GCFluids registry order.
Fixed walkways crash when loading into the world.
Fluids can now be placed and picked up properly inside FluidLoggable blocks.
Change Walkways placing behavior.
Upper Grating block can now be placed.
Allows bucket with non-water fluid can be placed into the block.
Change Grating GameTest position.
Added Grating GameTests.
Fuel bucket and Crude Oil bucket can be dispense by Dispenser.
Correct Fluid pickup sound on FluidLoggable blocks.

2023-05-08_17 14 49

Todo list

Broken walkways model rendering

SteveKunG commented 1 year ago

I think this PR is ready for review, I'm not familiar with FabricBakedModel so I would let someone know fixing those issues instead.

AlphaMode commented 1 year ago

Am I good to merge this @SteveKunG ?

SteveKunG commented 1 year ago

Yeah, go for it.