search

TeamGalacticraft / Galacticraft

The classic space mod, rewritten for modern versions of Minecraft.
MIT License
402 stars 85 forks source link

chore: Updating MachineLib tank mechanics #271

Closed supersimple33 closed 12 months ago

supersimple33 commented 1 year ago

This pr is paired with https://github.com/TeamGalacticraft/MachineLib/pull/6, it updates the machine lib version and flips Fluids to be registered after blocks which is important for pulling names from the registries, for example not doing so causes oil and fuel to call themselves air in the Tank view of machines.

supersimple33 commented 1 year ago

Blocked by https://github.com/TeamGalacticraft/MachineLib/pull/6. Need to wait for merge to give a commit hash code so I can set that hash to the machine lib version.

supersimple33 commented 1 year ago

no longer blocked by TeamGalacticraft/MachineLib#6

supersimple33 commented 12 months ago

Should I be targeting 1.19.4 or 1.20.1

supersimple33 commented 12 months ago

Also, #265 should fix the build check that's failing

AlphaMode commented 12 months ago

Ideally 1.20.1 but i can always just merge it

supersimple33 commented 12 months ago

All fixed up, you may want to merge #265 first as it will allow for passing the build action

SteveKunG commented 12 months ago

This commit break Grating and Walkways which handlers custom fluids blockstate. https://github.com/TeamGalacticraft/Galacticraft/pull/271/commits/5fc2f98f0904f0da3eb87500e8e913daabb62ede

supersimple33 commented 12 months ago

I'll see if I can find a workaround that keeps the original ordering but registers the names at the right time