TeamGalacticraft / Galacticraft

The classic space mod, rewritten for modern versions of Minecraft.
MIT License
402 stars 85 forks source link

fix: Working Oxygen Bubble Distributor #277

Closed supersimple33 closed 5 months ago

supersimple33 commented 11 months ago

This PR is blocked by TeamGalacticraft/MachineLib#9, that is why builds are failing.

I have made the Oxygen Bubble Distributor work. To do this I have:

There are also a number of other small changes to other oxygen systems. I am not 100% sure about the networking aspect of my impl here in terms of efficiency and multiplayer (I can't test this aspect) so please double check that part.

supersimple33 commented 11 months ago

I have also made some fixes to the Oxygen Sealer so that it acts correctly. To do this I have added a tryClearSeal method to OxygenSealerBlockEntity for better tear down when stopping the sealer. Also, I have removed the "Disable Seal" button from the screen, I don't think it makes sense to have it as players should be using the redstone configuration to turn the sealer on/off and this keeps the logic simpler.