TeamGalena / oreganized

https://curseforge.com/minecraft/mc-mods/oreganized
MIT License
5 stars 10 forks source link

Blocks with the `oreganized:blows_lead_cloud` block tag not spawning lead clouds when broken #68

Closed meeprdib closed 1 week ago

meeprdib commented 1 week ago

What happened?

Expected result - Blocks tagged with the oreganized:blows_lead_cloud tag should summon lead clouds when broken

Actual result - Blocks with the tag are broken normally.

image image

Mod Version

3.1.0

Minecraft Version

1.20

Relevant log output

No response

meeprdib commented 1 week ago

Did some more testing, seems like the tag is completely nonfunctional. Removing oreganized:lead_ore from the tag did nothing from preventing it from spawning the clouds. image image

meeprdib commented 1 week ago

Since the tag does nothing, why attempt to assign it to blocks via tags? https://github.com/TeamGalena/oreganized/blob/1.20.x/src/generated/resources/data/oreganized/tags/blocks/blows_lead_cloud.json You cannot assign block tags from item tags this way.

PssbleTrngle commented 1 week ago

That is not what this tag is for, it's used for the create/supplementaries compat where fans & bellows can blow off lead clouds from these blocks.

I will convert this into a feature request tho to move the cloud on breaking mechanic to also move to a tag-based system