Code Review Tools

[bfj5889]

Look for some good code review tools that have the following criteria: Free Used with GIT Possibly used with Slack Can possibly require acceptance before being pushed.

[danquack]

The way it’s done in industry is everyone creates their own private forks and then creates Pull requests. These pull requests are then approved or denied by the team. There also can be notification within slack and team members can make comments before Code is merged in.

-- Daniel Quackenbush Rochester Institute of Technology Computer and Information Technologies '18

On Sep 14, 2017, at 12:51 AM, Brianna Jones notifications@github.com wrote:

Look for some good code review tools that have the following criteria: Free Used with GIT Possibly used with Slack Can possibly require acceptance before being pushed.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

[bfj5889]

The way I have seen it done in industry is slightly different. I have seen that everyone will make their own branch for a feature and once their feature is complete they use a code review tool like Smartbear Collaboration to basically create diffs of all the files that were changed between their branch and the master. It also gives people a place to comment on and easily see what was changed. Then once the review has been completed the member can merge their branch into master/production. Most tools can be integrated into GIT and allow you to set reviewers.

[axk4545]

@bfj5889 @danquack I think that github has the code review tools you mentioned. If you want I can help configure them since I know them and that kinda fits with my sysadmin role

[axk4545]

@bfj5889 I will need more access to set it up. Feel free to revoke after it is configured.

[axk4545]

@bfj5889 please check that it functions the way you want and if so I will close this.

[bfj5889]

This can be closed