Open thierry-martinez opened 1 month ago
Is it emergency to support non-deterministic pattern? We can resolve this bug by removing get_measurement_order_from_flow
but I'm not really willing to remove it because there's a performance drawback(@nabe98 is tackling the performance issue but it will take more time).
For temporal solution, we can patch this by adding a new option to use flow based minimizing or not. Do you agree with this?
It is not an emergency but it is a common issue in Graphix. We need to know if the pattern is consistent with a gflow before applying some operations. If it turns out not to be the case then problems arise.
I think @shinich1 had an example. I planned on diving into what exactly happens in the graphical version of Elliott et al. but since you know that better than I do, might be a good idea. Another topic we can adress in July!
Describe the bug If a pattern has a graph with a flow but is not consistent with this flow,
minimize_space
leads to a pattern with is not runnable anymore.To Reproduce
Expected behavior
minimize_space
should preserve pattern runnability.