TeamGraphix / graphix

measurement-based quantum computing (MBQC) compiler and simulator
https://graphix.readthedocs.io
Apache License 2.0
55 stars 20 forks source link

Fixes issue #137 #159

Closed Roshan-Thomas closed 4 weeks ago

Roshan-Thomas commented 1 month ago

Context: Unitary Hack task for updating the tutorial and documentation style.

Description of the change: The following changes are implemented in this PR

Related issue: The related issue is #137.

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 71.82%. Comparing base (5194a88) to head (af47f85).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #159 +/- ## ========================================== - Coverage 71.84% 71.82% -0.02% ========================================== Files 30 30 Lines 5359 5359 ========================================== - Hits 3850 3849 -1 - Misses 1509 1510 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

shinich1 commented 1 month ago

Thanks, a few comments/requests before going into code review:

Roshan-Thomas commented 1 month ago

Hey @shinich1, my apologies for getting back to you pretty late, I had a lot of uni work to do.

I have completed the required changes,

The build can be found here. I ran the build a while back and it still hasn't completed. It successfully installed graphix and then remain stuck there.

Let me know if there are any more changes needed to be made.

shinich1 commented 1 month ago

Hey @shinich1, my apologies for getting back to you pretty late, I had a lot of uni work to do.

I have completed the required changes,

  • updated the code on the introduction and tutorial pages to reflect the latest changes to the codebase.
  • made the tutorial page a lot easier to follow, and
  • added graph visualizations on the tutorial page.

The build can be found here. I ran the build a while back and it still hasn't completed. It successfully installed graphix and then remain stuck there.

Let me know if there are any more changes needed to be made.

@Roshan-Thomas Thanks! the docs seems to have built fine (it takes time building all the examples from the code). I have a few remaining requests before merging:

Roshan-Thomas commented 4 weeks ago

Hi @shinich1, I have added the following changes,

Note: The logo was something I was not able to enlarge it as the spinxawesome-theme does not have that feature. I have searched in the documentation and there is no mention on how to increase the size of the logo. If you know of the method to do it, please let me know and I can implement it.

shinich1 commented 4 weeks ago

Hi @shinich1, I have added the following changes,

  • removed 'graphix documentation' on top-left corner
  • added code highlighting
  • changed tutorial heading levels as per request
  • updated the tutorial page to have simpler language as per request.

Note: The logo was something I was not able to enlarge it as the spinxawesome-theme does not have that feature. I have searched in the documentation and there is no mention on how to increase the size of the logo. If you know of the method to do it, please let me know and I can implement it.

@Roshan-Thomas Thanks a lot for looking into this. just a final request, would furo theme allow you to enlarge the logo? could you try with this logo file?

shinich1 commented 4 weeks ago

e.g. quimb docs has nicely-sized logo and they seem to use furo theme.

Roshan-Thomas commented 4 weeks ago

@shinich1 I have updated the theme to furo and got the logo (dark and light themed) to work.

Also, I had to place the dark and light logo in the _static folder as furo reads the images from the _static folder only, and for some odd reason the file paths to the logo folder was not working.

Hope this fixes all the issues and the changes required.

shinich1 commented 4 weeks ago

@shinich1 I have updated the theme to furo and got the logo (dark and light themed) to work.

Also, I had to place the dark and light logo in the _static folder as furo reads the images from the _static folder only, and for some odd reason the file paths to the logo folder was not working.

Hope this fixes all the issues and the changes required.

nice, it looks like the build failed - could you fix it? https://app.readthedocs.org/projects/graphix-uh/

Roshan-Thomas commented 4 weeks ago

fixed the issue, the furo package was not present in the requirements.txt. I have added it now (see last commit).

shinich1 commented 4 weeks ago

fixed the issue, the furo package was not present in the requirements.txt. I have added it now (see last commit).

will check once the build completed. I see lint CI failing below, could you black -l 120 the conf.py (see our guide)?

Roshan-Thomas commented 4 weeks ago

fixed the issue, the furo package was not present in the requirements.txt. I have added it now (see last commit).

will check once the build completed. I see lint CI failing below, could you black -l 120 the conf.py (see our guide)?

should I run the lint for any other files (other than conf.py)?

shinich1 commented 4 weeks ago

@Roshan-Thomas all look good now - I will merge this once tests passed and I checked things again. btw, I'd appreciate if you could star the repo, if not done yet :)

Roshan-Thomas commented 4 weeks ago

@Roshan-Thomas all look good now - I will merge this once tests passed and I checked things again. btw, I'd appreciate if you could star the repo, if not done yet :)

Thank you!