TeamGraphix / graphix

measurement-based quantum computing (MBQC) compiler and simulator
https://graphix.readthedocs.io
Apache License 2.0
64 stars 21 forks source link

Refactor `BaseM` #237

Open EarlMilktea opened 2 days ago

EarlMilktea commented 2 days ago

Context (if applicable):

Related to #178 .

Description of the change: (WIP)

codecov[bot] commented 2 days ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 78.99%. Comparing base (7da2095) to head (70cd3d4).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #237 +/- ## ======================================= Coverage 78.99% 78.99% ======================================= Files 40 40 Lines 6113 6114 +1 ======================================= + Hits 4829 4830 +1 Misses 1284 1284 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


🚨 Try these New Features:

EarlMilktea commented 2 days ago

@jemappellesami

I opened this PR to respect your initial motivation to introduce BaseM (add a way to simply specify the node subject to measure and nothing else), which is not properly reflected in the current code due to refactoring in process.

In addition to that, I have the following suggestion:

I feel it's clearer to use BaseM (or something derived from this) to specify everything about measurements, as the data required to perform measurement are essentially the same (angle, plane) though they can be missing at first. I would like to know in detail how you are trying to utilize the simulators without specifying the details, even while the simulators are initially designed for non-blind measurements.