Open EarlMilktea opened 2 days ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 78.99%. Comparing base (
7da2095
) to head (70cd3d4
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
🚨 Try these New Features:
@jemappellesami
I opened this PR to respect your initial motivation to introduce BaseM
(add a way to simply specify the node subject to measure and nothing else), which is not properly reflected in the current code due to refactoring in process.
In addition to that, I have the following suggestion:
MeasureMethod
and related thingsI feel it's clearer to use BaseM
(or something derived from this) to specify everything about measurements, as the data required to perform measurement are essentially the same (angle, plane) though they can be missing at first.
I would like to know in detail how you are trying to utilize the simulators without specifying the details, even while the simulators are initially designed for non-blind measurements.
Context (if applicable):
Related to #178 .
Description of the change: (WIP)
BaseM