Closed shinich1 closed 1 year ago
@shinichi1 All changes appear to be good. By the way, I find vop
makes the code a little complicated. As far as I understand, there shouldn't be any issues with merging vops into measurement angles and planes right after Pauli measurements(if my assumption is incorrect, please disregard this). I believe it would be better to do so because simple structure let users follow up easily. But, I think this modification should be done in another issue...
I'll fix a bug in flow finding algorithm, so please wait a moment.
By the way, I find
vop
makes the code a little complicated. As far as I understand, there shouldn't be any issues with merging vops into measurement angles and planes right after Pauli measurements(if my assumption is incorrect, please disregard this). I believe it would be better to do so because simple structure let users follow up easily. But, I think this modification should be done in another issue...
I agree, we will need to update angles as well as measurement planes, but that should be doable. I agree it would make things look much simpler. could you write up an issue for this?
I'll fix a bug in flow finding algorithm, so please wait a moment.
let's do this in a separate issue.
Before submitting, please check the following:
pytest
)black -l 120 <filename>
Then, please fill in below:
Context (if applicable):
Description of the change:
GraphState
graph state simulator, specifically,equivalent_graph_E2
methods
methodmeasure_x
andmeasure_z
methods for isolated nodesmeasure
method ofStatevectorBackend
:meas_op
is now done by application of Clifford gate conjugation on measurement operator, instead of interchanging of measurement axespattern.py
Related issue:
62
(#56)
also see that checks (github actions) pass. If lint check keeps failing, try installing black==22.8.0 as behavior seems to vary across versions.