search

TeamGraphix / graphix

measurement-based quantum computing (MBQC) compiler and simulator
https://graphix.readthedocs.io
Apache License 2.0
55 stars 20 forks source link

Probability calculation #69

Closed mgarnier59 closed 3 months ago

mgarnier59 commented 1 year ago

Is your feature request related to a problem? Please describe. So far, all backends rely on the fact that the probability of every measurement outcome is 1/2. That holds so far but it won't be the case for eg noisy simulations and maybe in other cases depending on the future developments.

Describe the feature you'd like Allow the user to specify if he/she wants to explicitly compute the probability. Indeed since it is not completely clear to me when this simplification is valid, maybe it's good to leave the choice to the user. For noisy simulation, I guess there won't be any choice. This would have to be done for all backends. This might require some backend updates to avoid useless computations (probability is an expectation value that itself relies on the evolve_single method)

Additional context NA

mgarnier59 commented 1 year ago

Working on it. Is it possible to open a draft PR for that issue?

shinich1 commented 3 months ago

@mgarnier59 Shall we close this issue? I believe this is done.

mgarnier59 commented 3 months ago

Yes indeed!