search

TeamHG-Memex / eli5

A library for debugging/inspecting machine learning classifiers and explaining their predictions
http://eli5.readthedocs.io
MIT License
2.75k stars 331 forks source link

Upgrade version of mypy #355

Closed zzz4zzz closed 4 years ago

zzz4zzz commented 4 years ago
codecov-io commented 4 years ago

Codecov Report

Merging #355 into master will increase coverage by <.01%. The diff coverage is 99.16%.

@@            Coverage Diff             @@
##           master     #355      +/-   ##
==========================================
+ Coverage   97.32%   97.32%   +<.01%     
==========================================
  Files          49       49              
  Lines        3137     3138       +1     
  Branches      584      584              
==========================================
+ Hits         3053     3054       +1     
  Misses         44       44              
  Partials       40       40
Impacted Files Coverage Δ
eli5/_graphviz.py 100% <100%> (ø) :arrow_up:
eli5/formatters/as_dict.py 95.83% <100%> (ø) :arrow_up:
eli5/base_utils.py 100% <100%> (ø) :arrow_up:
eli5/formatters/trees.py 100% <100%> (ø) :arrow_up:
eli5/sklearn_crfsuite/explain_weights.py 100% <100%> (ø) :arrow_up:
eli5/sklearn/unhashing.py 96.95% <100%> (ø) :arrow_up:
eli5/xgboost.py 99.39% <100%> (ø) :arrow_up:
eli5/formatters/html.py 100% <100%> (ø) :arrow_up:
eli5/utils.py 98.79% <100%> (ø) :arrow_up:
eli5/formatters/text_helpers.py 94.28% <100%> (ø) :arrow_up:
... and 26 more
zzz4zzz commented 4 years ago

@lopuhin I've checked your comments and made fixes. Additionaly I've added --ignore-missing-imports to mypy command line and cleaned up imports.

lopuhin commented 4 years ago

Thanks @zzz4zzz , and --ignore-missing-imports is also a welcome addition. I'll check PR in more detail later today or tomorrow.

lopuhin commented 4 years ago

Thanks for review @Gallaecio 👍