Add support for latest xgboost version

TeamHG-Memex / eli5

A library for debugging/inspecting machine learning classifiers and explaining their predictions

http://eli5.readthedocs.io

MIT License

2.76k stars 334 forks source link

Add support for latest xgboost version #407

Open aadu opened 3 years ago

aadu commented 3 years ago

eli5 fails when booster.feature_names is None, which is now the default behavior in xgboost when passing in a vanilla numpy array.

TypeError: 'NoneType' object is not iterable

See https://github.com/dmlc/xgboost/commit/9da2287ab8536e4fc35e3c6664af4597353fd257 for the relevant commit in xgboost

tjhallum commented 3 years ago

As per this post on StackOverflow, I was able to sidestep this issue by downgrading to from XGBoost version 1.4.2 to version 1.3.0 (apparently 1.3.0 is the latest version supported by ELI5).

However...being forced to downgrade XGBoost isn't a satisfactory solution.

ELI5 should be compatible with the latest version of XGBoost.

lopuhin commented 2 years ago

The fix was released in 0.13