search

TeamHG-Memex / scrapy-cdr

Item definition and utils for storing items in CDR format for scrapy
MIT License
7 stars 6 forks source link

Try fix py34 build #16

Closed lopuhin closed 6 years ago

codecov-io commented 6 years ago

Codecov Report

Merging #16 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #16   +/-   ##
=======================================
  Coverage   24.92%   24.92%           
=======================================
  Files           8        8           
  Lines         329      329           
=======================================
  Hits           82       82           
  Misses        247      247

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update afa0cb0...723162c. Read the comment docs.

lopuhin commented 6 years ago

Eh, looks like it does not fix anything, the issue is a race condition so it does not happen all the time. Will disable py34 for now. FTR, this is likely an issue https://github.com/pypa/setuptools/issues/951 and this is a failed build after merging this to master https://travis-ci.org/TeamHG-Memex/scrapy-cdr/jobs/294864437