TeamHG-Memex / soft404

A classifier for detecting soft 404 pages
56 stars 14 forks source link

remove "sudo: false" now that travis no longer supports it #17

Closed lucywang000 closed 5 years ago

lucywang000 commented 5 years ago

https://changelog.travis-ci.com/deprecation-container-based-linux-build-environment-82037

lopuhin commented 5 years ago

Looks like the build failure is due to an html-text update - https://github.com/TeamHG-Memex/html-text/pull/15 - I didn't realise that this was a breaking change. html-text removed parsel dependency, but we need it, so now we need to add it to soft404 dependencies instead.

codecov-io commented 5 years ago

Codecov Report

Merging #17 into master will decrease coverage by 2.81%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #17      +/-   ##
==========================================
- Coverage   92.77%   89.95%   -2.82%     
==========================================
  Files           5        5              
  Lines         249      249              
==========================================
- Hits          231      224       -7     
- Misses         18       25       +7
Impacted Files Coverage Δ
soft404/train.py 91.97% <0%> (-5.11%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d9ccc51...84b6b16. Read the comment docs.

lucywang000 commented 5 years ago

@lopuhin thanks for the guide, I have fixed it