search

TeamHHS / opp-api

0 stars 0 forks source link

some bugs(maybe) #24

Open lby-rgyyt opened 7 months ago

lby-rgyyt commented 7 months ago

  1. Duplicate User sign up error, after trying to sign up users with same info, it will return internal server error with code 500

  2. Upon sign up, it could be better to return a message saying “ sign up successfully” rather than return null.

3.for create card api, an user should not be able to input the balance by themselves.

botaoshi1 commented 7 months ago

  1. Solved, if the input username is already in the database, an error message "username is not available" will be returned.

  2. Solved.

  3. I think a user should be allowed to input balance as a simplified solution for getting info from bank. Otherwise it will be hard to test the function for insuffienct balance checking.