TeamHarTex / HarTex

Discord server management, reimagined.
GNU Affero General Public License v3.0
43 stars 9 forks source link

parse_duration bugs #23

Closed Splingush closed 3 years ago

Splingush commented 3 years ago

Hello! There seem to be some bugs in your parse_duration-function. I hope it is fine if I quickly list them here, instead of opening a pull-request:

[1] https://github.com/HT-Studios/HarTex-rust-discord-bot/blob/infdev/src/utilities/duration/mod.rs#L29 [2] https://github.com/HT-Studios/HarTex-rust-discord-bot/blob/infdev/src/utilities/duration/mod.rs#L46 [3] https://github.com/HT-Studios/HarTex-rust-discord-bot/blob/infdev/src/utilities/duration/mod.rs#L49

Cheers!

HTGAzureX1212 commented 3 years ago

Greetings, thank you for your thorough report! It is indeed a bug and has been confirmed to be reproducible. A fix will be deployed as soon as possible. Thank you again for your bug report! 👍

HTGAzureX1212 commented 3 years ago

A "temporary" bug fix is now deployed. Whilst there will still be a follow-up Pull Request to the code with the use of Result<T, E>. Thanks @Splingush!