[1.21]: Crash when opening fullscreen map

[BBoldt]

What happened?

When pressing the keybind to open the fullscreen map, game closes entirely.

Mod Loader

Fabric

Minecraft Version

1.21.x

Version

6.0.0

Relevant log output

https://gist.github.com/BBoldt/39b2785a174beafadb33f3d6d64d7cc9

[mysticdrew]

looks to be caused by dev.architectury.impl.fabric.ScreenInputDelegate$DelegateScreen.method_25400(ScreenInputDelegate.java:42)

[mysticdrew]

I added architectury and did not have a fail. So there is likely another mod that uses the api causing the conflict. My suggestion is to disable architectury, see what mods yell at you because it is not installed. Then start disabling those one by one to see which one is causing it so either I can try fixing it on my end or let them know what needs to be fixed.

[BBoldt]

Okay I'll try to figure out which one it is.

[BBoldt]

So, it's really strange. Seems to be something to do with this mod, Visual Overhaul. https://www.curseforge.com/minecraft/mc-mods/visual-overhaul

The issue stops when I have that mod disabled, but I can't reproduce the issue with only journeymap and visual overhaul. So it's clearly visual overhaul + journeymap + ??? = crash. I just can't figure out what is the final mod in the equation. At least it's fixed with visual overhaul disabled so that's something.

[mysticdrew]

That means adding VO and start adding other mods? What about achitectuary + vo + jm?

[mysticdrew]

It gets really difficult when there are several mods in combo breaking. I once had a combination of 4 mods causing JM to break. Took me a long time to figure it out.

[BBoldt]

I spent like an hour trying different mod combinations and kinda gave up. I looked through their issue tracker and noticed some similar issues with other mods involving GUIs being activated, but it must be certain combinations that trigger it.

https://github.com/TeamMidnightDust/VisualOverhaul/issues/

I also noticed some bugs there relating to other mods in my pack, so I ended up removing it.

[mysticdrew]

fair enough, thanks for putting in the effort. I'll leave this open for a bit so I can look into it when I get some time.

[tajemniktv]

Thanks for opening this issue, I was also faced with this crash but removing Visual Overhaul has helped

[mysticdrew]

Thanks for opening this issue, I was also faced with this crash but removing Visual Overhaul has helped

@tajemniktv do you happen to have a mod list? I have been trying to investigate this issue and have not been able to replicate it. Though VO has had some updates related to crash fixes, maybe they fixed it on their end?

[tajemniktv]

These are some of the recent logs I posted because of an issue with some other mod (full log from Prism, so java, mod list, specs etc.): https://mclo.gs/8XymbVM

Some things have changed, I added, removed and updated some mods since then, so I can try installing VO once again to check whether the issue in this modpack combo still persists when I get back to PC, but for now that's all I can provide... I'll get back to you in an hour or so

[mysticdrew]

These are some of the recent logs I posted because of an issue with some other mod (full log from Prism, so java, mod list, specs etc.): https://mclo.gs/8XymbVM

an issue with journeymap and another mod?

[tajemniktv]

an issue with journeymap and another mod?

Nah, it had to do with some connected textures and stuff. Here's the latest log with Visual Overhaul installed as well: https://mclo.gs/Dr3velI

Could the third mod causing this weird incompatibility be searchables? random guess basing on the crash report talking about some text field lol

[mysticdrew]

No, it is a text field in the fullscreen map. Something is injecting in to Minecraft's Screen class and probably breaking the init method.

In prism, can you add this -Dmixin.debug.export=true to the java arguments section. Run the game, make the crash happen.

Then in the minecraft folder, there will be a new folder called .mixin.out in there can you attach the file. net.minecraft.class_437.class please

[tajemniktv]

Logs: https://mclo.gs/IVlibGV Had to put it into the zip: class_437.zip I hope I went into the right folder lol

[mysticdrew]

Thanks!! Okay.. so this gave me a bit more to go on, but still a mystery. Can you disable architectury API and give me a list list of mods that blow up without it? A mod that depends on architectury is causing the issue, so this will narrow it down significantly.

[tajemniktv]

Huh, that's interesting

[mysticdrew]

Hmm, thanks. I figured there would be more? Maybe fabric only reports the first one loaded

[tajemniktv]

Yeah that's why I'm also surprised - I turned off this JamLIB mod and waiting for a game to start, but it's not only taking some time but I can also see a shit ton of errors in console related to... REI?

EDIT: Ah wait, shedaniel is also the author of architectury...

EDIT2: I can't seem to get into the game without JamLib and architectury - the game stops logging as it hits the limit in seconds and freezes Prism completely

EDIT3: of course it's not giving any dependencies, simply freezes

EDIT4: well, uh, I disabled JamLib, no errors whatsoever - the game still crashes with VO while opening fullscreen map

[mysticdrew]

Okay so not related architectury then since you removed it and jamlib. This is all so confusing. Is this a public pack?

[tajemniktv]

Actually when I remove both architectury it just won't load my game and simply freeze it. Here are logs from trying to run it without Architectury: https://mclo.gs/PPmK6EN I can try without REI, maybe?

The pack I'm using is made by me, basically throwing everything I find interesting, I can send you a zip or mrpack if you might need it

[mysticdrew]

It is fancy menu + vo

[mysticdrew]

It is fancy menu + vo

[mysticdrew]

OOPS didin't mean to close it

[tajemniktv]

shit bruh, no way

[mysticdrew]

yea, the class file you sent me earlier, i was going through that and adding mods one at a time that inject into the screen class.

[tajemniktv]

Ah damn, glad I could be somehow helpful. Pity, I find fancymenu pretty useful, especially in modpacks that add a lot of buttons. I wonder is there a way to block Fancymenu to stop from injecting into that one screen class? i believe i saw that option somewhere in their settings, not sure whether that completely blocks it tho. is that fixable from your side, or should we create an issue for fancymenu and/or VO?

[mysticdrew]

I can probably fix it, I think I see what the issue is. Though, not sure why FM + VO causes the issue, I would think just FM would cause it.

[tajemniktv]

Yeah, that's interesting, what role does VO play here? Maybe the icons on the buttons somehow break things?

edit: well, disabling them in VOs config didn't do anything so I guess not, unless they anyway intercept the screen somehow, not sure how these things work, so idk why im even trying to guess XD

[mysticdrew]

Okay, I have this fixed for the next beta release. This was related to some buttons on the fullscreen map. Seems the combination of FM and VO called methods in the constructor before the button was full built, causing an NPE.

I will close once it is released

[tajemniktv]

Incredible, thanks for your work drew!

[mysticdrew]

1.21-6.0.0-beta.15 with the fix is publishing, should be available in the next 30 minutes

[tajemniktv]

Can confirm that it now doesn't crash and works just fine with VO and other 200+ mods:))