TeamJM / journeymap

JourneyMap mod for Minecraft
http://journeymap.info
127 stars 10 forks source link

[Crash][1.21.1][Fabric]: Crash upon opening waypoint manager #780

Closed DisdainofDeimos closed 1 month ago

DisdainofDeimos commented 1 month ago

What happened?

After setting up waypoint groups and color schemes (using forced color override feature for grouping), the game now crashes upon opening the waypoint manager screen. This is replicate-able from both the waypoint manager hotkey, and the waypoint manager button in the fullscreen map. Crash report with mod list link

Seems to be a problem with the getColor being = null, I am unsure as to the reason for this.

Mod Loader

Fabric

Minecraft Version

1.21.x

Version

6.0.0

Relevant log output

crash-2024-08-30_14.46.22-client.txt journeymap.log latest.log

mysticdrew commented 1 month ago

aaah okay, likely because you didn't set a color when you saved a force override. I will get this fixed, thanks for the report. While testing this, looks like there is an issue with changing colors of a group too for some reason, it worked at one point. I guess I broke it somehow.

mysticdrew commented 1 month ago

if you want to pass me your waypointdata.dat file in here I can fix it quick for you so you can use your waypoint manager while I work on releasing a fix. it is located in C:\Users\matta\AppData\Roaming\ModrinthApp\profiles\2024 - Alibrealm (3)\journeymap\data\mp\Squeak\waypoints\WaypointData.dat Just drop it in a response here.

DisdainofDeimos commented 1 month ago

Yeah I did some further testing just now, and the waypoint manager still works just fine in a fresh singleplayer world without any waypoints or groups, so your explanation seems to fit! Thanks for the quick response, here's that WaypointData file (it won't let me upload a .dat so I changed the file extension to .txt temporarily, I can also put a drive link if changing the file extension messes something up!) WaypointData.dat.txt

Thanks again <3

mysticdrew commented 1 month ago

WaypointData.dat.txt See if this works for you.

DisdainofDeimos commented 1 month ago

image Were back in business! Thanks so much for your time and for the personal fix <33 Love your work, thanks for everything you give the community!

mysticdrew commented 1 month ago

image Were back in business! Thanks so much for your time and for the personal fix <33 Love your work, thanks for everything you give the community!

Awesome thanks! I will get this bug fix out tomorrow hopefully. Other than this issue, what are your thoughts on the new waypoint manager? Like it, love it, hate it? Improvements I can make?

DisdainofDeimos commented 1 month ago

I love it! It's great being able to have groupings although I would like to see a quick and easy button to instantly hide/show whole groups of waypoints at a time, and maybe expanding on the icon choices for both individual waypoints and groups? All-in-all you've made (IMO) the best Minecraft mapping mod for both casual and veteran/technical players, great stuff!

mysticdrew commented 1 month ago

I love it! It's great being able to have groupings although I would like to see a quick and easy button to instantly hide/show whole groups of waypoints at a time, and maybe expanding on the icon choices for both individual waypoints and groups? All-in-all you've made (IMO) the best Minecraft mapping mod for both casual and veteran/technical players, great stuff!

Icons are coming for groups. So more icons can be added easily via resource packs. I only provided the default ones for now Details on adding new icons via resource packs. (not documented yet) https://github.com/TeamJM/journeymap-docs/issues/90

The group panel is getting a bit squished already, we are a bit limited on space, I cannot make it larger really because unlike you and I, many people still do not adjust their GUI scale. So I have to make it all fit in scale 4, which sucks. but I will see what I can do.

mysticdrew commented 1 month ago

image I was able to make it work :)

DisdainofDeimos commented 1 month ago

Awesome! That will be a really convenient feature to have especially on large / long playtime servers/worlds with lots of waypoints! Great stuff friend :)