TeamJM / journeymap

JourneyMap mod for Minecraft
http://journeymap.info
129 stars 10 forks source link

[Bug]: Group Waypoint Toggle #808

Open 100xdonaldx001 opened 4 hours ago

100xdonaldx001 commented 4 hours ago

What happened?

The Group Waypoint toggle doesnt work on all Group waypoints.

It either does none or only a couple like 1-2

Example: Farming Group is off: image

Example Farming group is on: image

A Temporary resolve is to edit every Waypint manually but as visible on some of my groups there It can take a while for it to toggle on and off manually.

Mod Loader

Forge

Minecraft Version

1.21.x

Version

6.0.0

Relevant log output

No response

mysticdrew commented 4 hours ago

Enabling/Disabling groups does not update the waypoints.

So if you have 2 waypoints enabled, 10 disabled. You disable the group, now it shows all waypoints are disabled because the group is enabled. But, if you turn the group back on, it will not enable the waypoints that were previously disabled. It will only enable the waypoints that were already enabled. This is the intended behavior.

mysticdrew commented 4 hours ago

to enable/disable all the waypoints themselves in the group, click the button on the top header line of the waypoints. image

100xdonaldx001 commented 3 hours ago

to enable/disable all the waypoints themselves in the group, click the button on the top header line of the waypoints. image

I would understand if that would be the case but it isnt. It does the same as the left toggle for the group

And additionally when that bug occours i cant even toggle the waypount itself with the toggle button next to it. I would need to edit the waypoint in order to re-enable it again.

See here: https://github.com/user-attachments/assets/a36818a4-13c5-448f-b721-e41fa2b5cf5f

as you see the waypoint i edited was already enabled but just didnt showd up as enabled even tho the group was enabled. This is the same case for the other waypoints i had in that list.

mysticdrew commented 2 hours ago

What beta version are you on? I am unable to replicate this. Can you please send me your waypoints.dat file for this world please?

100xdonaldx001 commented 1 hour ago

Its beta version 27 (latest) image

And hers the Waypoint file in zip cause Github doesnt allow .dat files: WaypointData.zip

Also as a sidenote: i dont know if that issue also happens in Singleplayer since i dont really play SP It happenes on the server Wynncraft so dont know if a Multi-Server setup causes the issue there.

mysticdrew commented 1 hour ago

Thanks, looking into it.

mysticdrew commented 1 hour ago

Does restarting fix it? With your waypoint file, I see no issues. Everything is working as intended. I will load up wynn craft and see I suppose.

Can you give me a step by step on reproducing it? Maybe I am doing something wrong here.

100xdonaldx001 commented 1 hour ago

I dont really have a step by step instruction for the issue. it randomly happens.

Like i join the hub and everything works as intended. I can do everything toggle waypoints, toggle group, toggle all I then join the server and sometimes everything still works sometimes tho i cant toggle waypoints, toggle groups works for some but not all groups Toggle all waypoints work in some but not all groups.

Tho when i am on an server and toggle all waypoints and then reconnect to the hub all waypoints then are activated. so when i join a server again they show and ican do everythign with them again like disable enable toggle all.

So i cant really tell where exactly the issue is even tho i would like to.

mysticdrew commented 1 hour ago

I was able to replicate it on the server. I wonder if changing dims in SP does it too.

mysticdrew commented 1 minute ago

Okay, I think I found the problem. If you pop into our discord, i can give you a test build to verify.