TeamLapen / Vampirism

A Minecraft mod called Vampirism
https://vampirism.dev
Other
190 stars 56 forks source link

Umbrella does not work in off-hand #1413

Open MrLeonardosMi opened 1 month ago

MrLeonardosMi commented 1 month ago

Minecraft Version

1.20.1

(Neo)Forge Version

47.2.1

Vampirism Version

1.10.7

Modpack

No response

Singleplayer/Multiplayer

Server

What happened?

If you take Vampire Umbrella in your second hand and then move it to your main hand via F, the slow(-35 speed) effect of the umbrella is lost.

Relevant log output

No response

Reproduce steps

  1. Take an umbrella
  2. Put it in your left hand
  3. Pass it through F to the right hand, the slowdown disappears

https://youtu.be/5FGcDwtMaZY https://youtu.be/dfiFg76hKi4

Other relevant mods

No response

maxanier commented 1 week ago

Thank you for reporting.

This is actually somewhat intentional. If you hold the umbrella in your off-hand, it does not protect you from the sun, so it also does not slow you down. This decision was made to nerf the umbrella. You should not be able to do anything else while holding the umbrella. It is just meant as a last reserve if you really must go through the sun.

However, it is also disabled by default, so maybe we can rethink this decision, or alternatively add a model of a closed umbrella that is used in the off-hand.