search

TeamLapen / Werewolves

addon mod for Vampirism which add Werewolves
https://wiki.werewolves.dev
GNU Lesser General Public License v3.0
36 stars 12 forks source link

Broken Sound Effects fix #161

Closed TheDrOfDoctoring closed 9 months ago

TheDrOfDoctoring commented 9 months ago

Previously (since 7590588) , sound effects, that were added by this mod, did not work because they were registered using Vampirism's mod id.

This applied to things such as the sound effect when biting enemies and howling, meaning no sound was played. Noticed this today whilst testing werewolves in my Ageing addon.

Very simple fix, but wanted to make this a PR since I haven't done one before and wanted to learn how to use them properly but it seems reasonable enough for a pr. Because of that I'm not sure if something as simple as this should just be done through an issue.

Cheaterpaul commented 9 months ago

Thanks for bringing this up.

I always have my dev environment Minecraft instance muted :smile:

A issue would suffice. But it is event better if you have fun doing a PR or already did the legwork and identified and fixed the problem. I appropriate your involvement and contributions either way. It's more fun when more people are involved.