search

TeamLumi / luminescent-team

GNU Affero General Public License v3.0
12 stars 5 forks source link

Add Zone Code Matching (PL #18) #104

Closed AarCon closed 3 weeks ago

AarCon commented 4 months ago

https://docs.google.com/spreadsheets/d/12Xguf7vRrA37K--pAW4qseCmwT-m56rXgCxE8TRkQ2U/edit#gid=0

This will be performed on the Luminescent Team Dev fork after the canvas-highlight-performance-fix branch has been merged.

Currently, we only match locations to names. We need to add functionality to match a name to zone codes (c01, t02, etc.) and zoneIDs. Each of these can be found in the areas_updated.csv. There are also functions that can be found with this functionality in https://github.com/TeamLumi/luminescent-team-dev/blob/bug/canvas-highlight-performance-fix/src/utils/dex/location.js.

We should also match the names that are in the areas_updated.csv to have parity across all utils.

AarCon commented 3 weeks ago

Done better by using zoneID instead. Will need to rewrite the locations for the shop items but can be done in a future update. Closed with #114