Use URL params OR query params to share Pokemon URLs

TeamLumi / luminescent-team

GNU Affero General Public License v3.0

12 stars 5 forks source link

Use URL params OR query params to share Pokemon URLs #43

Closed Glup3 closed 4 months ago

Glup3 commented 1 year ago

It would be nice to be able to share an URL with a Pokemon. This could be achieved by using URL parameters or query parameters. Docusaurus is using react router v5 underneath the hood.

Possible solution for URL parameters: https://stackoverflow.com/questions/63271765/how-to-integrate-dynamic-routes-in-docusaurus-with-react-router

Solution for query parameters: https://v5.reactrouter.com/web/example/query-parameters

Glup3 commented 1 year ago

Things still needs to be considered:

how does the URL look like? what query param are we using? pokemonId? monsNo? pokemon form name?
autocomplete needs a list of all ENABLED pokemons, and not just index from 0 to n

once those are discussed & resolved, use the code in #49 as reference and complete the feature