search

TeamMeanMachine / meanlib

A Kotlin FRC library
The Unlicense
16 stars 3 forks source link

Fix JitPack builds #3

Closed andrewda closed 5 years ago

andrewda commented 5 years ago

Fixes JitPack builds so that meanlib can be imported with maven.

Failing log: https://jitpack.io/com/github/TeamMeanMachine/meanlib/bunnybots2018-310b857ab1-1/build.log Fixed log: https://jitpack.io/com/github/SouthEugeneRoboticsTeam/meanlib/bunnybots2018-0c9ebadb7e-1/build.log

tylerscheuble commented 5 years ago

Thanks for the PR!

Unfortunately this breaks our builds with this message:

Plugin request for plugin already on the classpath must not include a version

It seems that adding the version fails when using the library as a subproject (like in our Robot-Template repo), but omitting it fails when you try to build it on it's own, or though JitPack.

I've pushed a commit that loads the Kotlin plugin with the old apply plugin syntax, and both ways seem to be working fine on my end. Does this fix your issue?

andrewda commented 5 years ago

Yep looks like that fixes the issue! Thanks!