TeamMeanMachine / meanlib

A Kotlin FRC library
The Unlicense
17 stars 3 forks source link

Cleaned `MeanlibRobot` of unused prints and defs #30

Closed betapictoris closed 1 year ago

betapictoris commented 1 year ago

Changes

betapictoris commented 1 year ago

We still want the println for autonomous so this shows up in the logs.

Wouldn't autonomous() be overridden anyway, or are there times when autonomous() is called without being overridden? If so, shouldn't we consider a more descriptive warning, such as "The autonomous mode was called without being overridden, consider overriding it to enable this mode"?

jcrowell commented 1 year ago

There are times where this might not be overridden. It might be nice to add a note to the comment indicating the autonomous was not overwritten but this is not strictly necessary.

betapictoris commented 1 year ago

I've added a message that tells the user that autonomous mode wasn't implemented by them.