TeamMentor / Master

TEAM Mentor 3.x Released Code
16 stars 17 forks source link

Proxy Installer - Uninstall does not remove all directories #723

Open romichg opened 10 years ago

romichg commented 10 years ago

This directory still exists: C:\Security Innovation\TeammentorCheckmarx\aspnet_client\system_web\4_0_30319

michaelhidalgo commented 10 years ago

I opened an case in InstallShield , they said this folder was created by ASP.NET and therefore InstallShield does not remove it.

Dear Michael,

Your case # 00331043: Uninstall web application iissue: aspnet_client folder not removed. has been updated with the following comment: Hi Michael,

As you have found this is a directory created by Asp.net when it is enabled on your site. There is a thread discussion regarding this below: http://forums.asp.net/t/1060269.aspx?How+to+create+a+flipcart+like+panel+for+showing+products+in+gridview

Since the installer is not the one creating the directory, it is treated as user data and is not removed during uninstallation. This is an expected behavior of Windows Installer: http://msdn.microsoft.com/en-us/library/ms954376.aspx

Sincerely, Justin

Flexera Software Technical Support installshieldsupport@flexerasoftware.com

Please do not reply to this email. Instead click the link below to use a web form to send a reply: http://flexerasoftware.force.com/casecommentform?CaseId=500G000000LQBCQ

Please click on the link below to view this case in the Self-Service portal. http://flexerasoftware.force.com/

Thank you, Flexera Software Support

romichg commented 10 years ago

But why can't we remove the folder ourselves?

On Fri, Mar 14, 2014 at 3:53 AM, Michael Hidalgo notifications@github.comwrote:

I opened an case in InstallShield , they said this folder was created by ASP.NET and therefore InstallShield does not remove it.

Dear Michael,

Your case # 00331043: Uninstall web application iissue: aspnet_client folder not removed. has been updated with the following comment: Hi Michael,

As you have found this is a directory created by Asp.net when it is enabled on your site. There is a thread discussion regarding this below:

http://forums.asp.net/t/1060269.aspx?How+to+create+a+flipcart+like+panel+for+showing+products+in+gridview

Since the installer is not the one creating the directory, it is treated as user data and is not removed during uninstallation. This is an expected behavior of Windows Installer: http://msdn.microsoft.com/en-us/library/ms954376.aspx

Sincerely, Justin

Flexera Software Technical Support installshieldsupport@flexerasoftware.com

Please do not reply to this email. Instead click the link below to use a web form to send a reply: http://flexerasoftware.force.com/casecommentform?CaseId=500G000000LQBCQ

Please click on the link below to view this case in the Self-Service portal. http://flexerasoftware.force.com/

Thank you, Flexera Software Support

Reply to this email directly or view it on GitHubhttps://github.com/TeamMentor/Master/issues/723#issuecomment-37556979 .

michaelhidalgo commented 10 years ago

It seems there is a way to remove it using some scripting inside the installer, there is a built-in method called RemoveDir, however does not seem to work very well because at the stage it is fired, the folder it's still in use, so removing the folder does not work properly.

I'm digging into this to determine where should be fired.

michaelhidalgo commented 10 years ago

Fixed https://github.com/michaelhidalgo/RomanInstaller

romichg commented 10 years ago

Unable to test before https://github.com/TeamMentor/Master/issues/749 is resolved

michaelhidalgo commented 10 years ago

Fixed here https://github.com/michaelhidalgo/RomanInstaller