Space bar should be used to move down one screen at a time (Flare)

wwhyte-si commented 9 years ago

When I scroll down using the space bar I would like the bottom line of the previous screen to scroll up to be immediately under the search bar -- i.e. so that I can see the last line of context from my previous view, followed by the next screenful of content.

However, the bottom line scrolls up further than that, it seems like it is going to the top of the search bar. This means that the search bar is hiding some of the results and I need to arrow-key back up a couple of lines.

The first image below shows the first results screen I see. The second image below shows what I see after one space bar push. The final image shows what I'd expect to see.

first screen second screen better screen

romichg commented 9 years ago

Thanks. Yes very good point. This will be fixed in the Flare (JS) version. For this version this will probably need to be a known limitation, at least for the time being. I will follow up with you when it is fixed.

wwhyte-si commented 9 years ago

Thanks!

sent from my phone On Mar 22, 2015 1:46 PM, "RomichG" notifications@github.com wrote:

Thanks. Yes very good point. This will be fixed in the Flare (JS) version. For this version this will probably need to be a known limitation, at least for the time being. I will follow up with you when it is fixed.

— Reply to this email directly or view it on GitHub https://github.com/TeamMentor/TM_4_0_Design/issues/600#issuecomment-84672672 .

luchia commented 9 years ago

Prioritising my Sprint 3 work.

luchia commented 9 years ago

I've done some researching today and it looks like this is dependant on the users browser. It's possible that we could adapt a JS library to fix this but in Jade version of TM it's impossible to do.

luchia commented 9 years ago

Changing back to P1.

romichg commented 9 years ago

Still showing up as P0, moving it to P1

luchia commented 9 years ago

This isn't possible to do without doing some weird hacks. It's browser standard, it takes you to one screen-height further down than you were before. I don't know if this is something we want to fix or not?

wwhyte-si commented 9 years ago

If the space bar takes you down one screen height we shouldn’t use widgets that effectively change the definition of screen height without telling the browser. If you’re used to using the space bar to page down, as I am, this behavior is terribly frustrating.

Cheers,

William

From: Luchia Bloomfield [mailto:notifications@github.com] Sent: Saturday, May 16, 2015 9:05 PM To: TeamMentor/TM_4_0_Design Cc: wwhyte-si Subject: Re: [TM_4_0_Design] Space bar scroll hides text behind the search bar (#600)

This isn't possible to do without doing some weird hacks. It's browser standard, it takes you to one screen-height further down than you were before. I don't know if this is something we want to fix or not?

— Reply to this email directly or view it on GitHub https://github.com/TeamMentor/TM_4_0_Design/issues/600#issuecomment-102717650 .

wwhyte-si commented 9 years ago

In other words, I would rather not have the search bar as a floating element within the results screen, but as an element in a different screen. Can we do that?

sent from my phone On May 16, 2015 9:04 PM, "Luchia Bloomfield" notifications@github.com wrote:

This isn't possible to do without doing some weird hacks. It's browser standard, it takes you to one screen-height further down than you were before. I don't know if this is something we want to fix or not?

— Reply to this email directly or view it on GitHub https://github.com/TeamMentor/TM_4_0_Design/issues/600#issuecomment-102717650 .

romichg commented 9 years ago

Yes, we should fix this issue, just not in this version :) This should be addressed in Flare, which is a jazzier version of TM.

wwhyte-si commented 9 years ago

I'm fine with fixing it later :-)

On Sun, May 17, 2015 at 1:08 PM, RomichG notifications@github.com wrote:

Yes, we should fix this issue, just not in this version :) This should be addressed in Flare, which is a jazzier version of TM.

— Reply to this email directly or view it on GitHub https://github.com/TeamMentor/TM_4_0_Design/issues/600#issuecomment-102823502 .

luchia commented 9 years ago

JS library that will handle this.

luchia commented 9 years ago

I ended up not having to use a JS library because I spent the time planning Flare properly (no CSS hacks). Here's what it looks like when you use the space bar to move down the page -

Article

article

Main

main

Navigate

navigate

romichg commented 9 years ago

There is a small issue here. In order for me to use the space bar, I actually need to click on the page. For example, if I click on the article title, I then need to click on the page for the space bar to work.

luchia commented 9 years ago

Okay, we will need to do this with JS then. I sent Dinis a message on Slack regarding this. Here's a few more options to consider:

https://github.com/bfanger/angular-keyboard http://chieffancypants.github.io/angular-hotkeys/

romichg commented 9 years ago

@DinisCruz any ideas how we can get this done?

DinisCruz commented 9 years ago

this is related to the pagination issues that @michaelhidalgo is working on (and scrolling) so pushing this to him

TeamMentor / TM_4_0_Design