TeamMetallurgy / Aquaculture

Aquaculture is an expansion of Minecraft's base fishing system. It allows you to catch a variety of new fish with a brand new series of rods and tools
69 stars 72 forks source link

Unable to join server #192

Closed WenXin20 closed 3 years ago

WenXin20 commented 3 years ago

Minecraft v1.16.4 Forge v35.1.28 Aquaculture v2.1.11 BYG v1.1.7-Beta-1 BOP v13.0.0.427

I am unable to join my server when Aquaculture, Biomes You'll Go, & Biomes O' Plenty is installed. If I remove any of these mods, I can join the server on my first try, but when combined, I am constantly kicked when I try to join the world. I didn't notice anything in the logs, but I am able to reproduce this with these 3 mods. Server Log Client Log

2021-01-09_00 26 28

GirafiStudios commented 3 years ago

Thank you for setting up your issue in a very presentable way - and provide mods and version of everything you're using! Wish everybody did it like this, would save a lot of time in a lot of cases.

Tried reproducing the issue with the exact mods and version you were using, without any problems. Tried running it on both a local server and on a dedicated Linux based server (Like you're running it on).

Only thing that I really noticed from the logs, were that you were using an very old version of Java 8 - which could cause various problems. I would recommend making sure you're running the latest version of Java 8. It could also just be simply the fact that it's taking too long to join (Can be caused by bad internet or bad ping to the server). Setting the JVM parameter "-Dfml.readTimeout=180" on both your server and client might fix it, so that's worth a try :)

WenXin20 commented 3 years ago

Yeah, it took me a while to figure out what was causing it. I'll try updating java to see if that helps.

WenXin20 commented 3 years ago

I've updated both java and forge, but I'm still getting disconnected after only a couple of seconds. I've added the timeout to my client. The pebblehost server already has it disabled it seems.

If I remove aquaculture, I can add other mods and connect just fine to the server, but as soon as I add it back, it disconnects me again. So I'm not sure that it's a read timeout issue.

GirafiStudios commented 3 years ago

Have you tried using the previous version of Oh The Biomes You'll Go?

WenXin20 commented 3 years ago

I used v1.1.6 as well, but had the same problem. I haven't tried any previous versions yet though.

GirafiStudios commented 3 years ago

Yea version 1.1.6 was what I meant, no reason going further back than that.

Could you try setting up a server on your own PC and see if it happens then too? I'm curious if it perhaps could be caused by the host you're using.

WenXin20 commented 3 years ago

Just finished getting the local server set up, but it is still disconnecting me.

GirafiStudios commented 3 years ago

Could you try turning off fish mob spawning in the config, and see if it still happens?

WenXin20 commented 3 years ago

Ok, I was able to login on the first try after disabling fish spawning.

GirafiStudios commented 3 years ago

Interesting. So it is a thing with it taking too long to load most likely then. I noticed it says Twitch in the log. Are you still using the old Twitch Launcher, or are you using the CurseForge launcher?

WenXin20 commented 3 years ago

I'm using the CurseForge launcher.

GirafiStudios commented 3 years ago

Alright, good good. Did you set the "-Dfml.readTimeout=180" on your local server, when trying it there?

WenXin20 commented 3 years ago

Just tried it with the same results. It only connects if fish spawning is set to false.

GirafiStudios commented 3 years ago

Hmm, okay. Could you try catching a Aquaculture fish (Disabling fish spawning is fine for that). Enabling debug mode in the config and using a Neptunium Rod will allow you to get instant catches - just keep going until you get a Aquaculture fish. Will help me track down what code exactly your setup doesn't like.

WenXin20 commented 3 years ago

I don't see anything printed in the log when fishing, even with debug enabled in the config. Client Log Server Log

GirafiStudios commented 3 years ago

What I wanted you to test is if you were able to catch an Aquaculture fish - as some of the same code is used for the fish spawning.

WenXin20 commented 3 years ago

Oh, yeah, I was able to catch fish.

GirafiStudios commented 3 years ago

Just noticed. You're still using the built-in version of Java on your client. Here's how you change it:

If that doesn't work, I'm gonna send you a custom version of Aquaculture 2 to further track down the issue.

WenXin20 commented 3 years ago

I changed it to "Program Files (x86)\Java\jre1.8.0_271\bin\javaw.exe", but it won't launch with it.

GirafiStudios commented 3 years ago

Does it throw any sort of error, or?

WenXin20 commented 3 years ago

This is what pops up: Capture

GirafiStudios commented 3 years ago

Apparently CurseForge does not save it, after you've set it.. So I guess you're forced to using an ancient version of Java atm. But that's not the problem then, as I was using the CurseForge launcher too.

Could you try using this version? https://mega.nz/file/NAg3hSiI#TWyGSFFxr9Vubuc3XdXrRMbdgNnBdr9ffAD-pUEV62Q With fish spawning enabled. It's not a fix, I'm just curious if that would work. If that works, that means that it's the large amount of biomes that's causing it.

WenXin20 commented 3 years ago

Yep, that worked.

GirafiStudios commented 3 years ago

Alright, thanks! I'll try to work something out. It's very difficult, as I don't a lot to go on - but at least I have some now. If you haven't already, could you try allocating more RAM for the instance?

WenXin20 commented 3 years ago

Cool, thanks! And I've already given it 9GB for ram, since I usually run it with a modpack.

GirafiStudios commented 3 years ago

That should be more than enough yea. I've tried moving some of the code to during load time, instead of on world join. Should help performance overall, hopefully it'll be enough to solve your issue. https://mega.nz/file/Qcx0FZAC#yM39ABaOdSyjd8tJBRw1HiDFVR5akjBlGpzv9KVwtXY

WenXin20 commented 3 years ago

I think that fixed it. :) I was able to join on the first try.

GirafiStudios commented 3 years ago

Really!? Perfect then! Just to make sure, are you finding any Aquaculture fish spawns? Probably easiest in an ocean biome. If you're not quite sure if it's an Aquaculture fish or not, Middle-Click on it - if it gives you a Fish in a Bucket, it's an Aquaculture fish :)

WenXin20 commented 3 years ago

Yep, they're spawning. It was fun using the /tp @e WenXin2 command. :D

GirafiStudios commented 3 years ago

Sounds good :) Clever use of that command, never thought about it being used like that! Thank you very much for being willing to help track down the issue! A lot of the time people don't want to put any effort into their issue being resolved.

WenXin20 commented 3 years ago

No problem!